Remove mode from GoArchive (#4028)

**What type of PR is this?**
Cleanup

**What does this PR do? Why is it needed?**
Looks like we can use the mode from the `source` instead and reduce the
chance of inconsistencies

**Which issues(s) does this PR fix?**

Fixes #

**Other notes for review**

go/private/actions/archive.bzl

@@ -218,5 +218,4 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
         cgo_deps = depset(transitive = [cgo_deps] + [a.cgo_deps for a in direct]),
         cgo_exports = cgo_exports,
         runfiles = runfiles,
-        mode = go.mode,
     )

go/private/tools/path.bzl

@@ -26,7 +26,6 @@ load(
     "GoArchive",
     "GoPath",
     "effective_importpath_pkgpath",
-    "get_archive",
 )
 
 def _go_path_impl(ctx):
@@ -35,10 +34,11 @@ def _go_path_impl(ctx):
     # package may also appear in different modes.
     mode_to_deps = {}
     for dep in ctx.attr.deps:
-        archive = get_archive(dep)
-        if archive.mode not in mode_to_deps:
-            mode_to_deps[archive.mode] = []
-        mode_to_deps[archive.mode].append(archive)
+        archive = dep[GoArchive]
+        mode = archive.source.mode
+        if mode not in mode_to_deps:
+            mode_to_deps[mode] = []
+        mode_to_deps[mode].append(archive)
     mode_to_archive = {}
     for mode, archives in mode_to_deps.items():
         direct = [a.data for a in archives]

go/providers.rst

@@ -331,10 +331,6 @@ which is available through the :param:`data` field.
 +--------------------------------+-----------------------------------------------------------------+
 | The files needed to run anything that includes this library.                                     |
 +--------------------------------+-----------------------------------------------------------------+
-| :param:`mode`                  | :type:`Mode`                                                    |
-+--------------------------------+-----------------------------------------------------------------+
-| The mode this archive was compiled in.                                                           |
-+--------------------------------+-----------------------------------------------------------------+
 
 GoPath
 ~~~~~~