-
-
Notifications
You must be signed in to change notification settings - Fork 665
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cleanup importpath/importmap handling in go_context (#4052)
**What type of PR is this?** Starlark cleanup **What does this PR do? Why is it needed?** This looks like a 50-100ms speedup from avoiding the array allocation in infer_importpaths and reduced `getattr` calls. Is `getattr` slower than direct property access? (If not, we can avoid passing in the values from go_library) **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
- Loading branch information
Showing
3 changed files
with
40 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters