-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate new values for stamping introduced in 0.22.0 to language rules #2011
Comments
@alexeagle do you think this suggestion would make sense? |
Yes, for sure, thank you for the description in the linked issue as well. |
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
Dear bot, please don't close this issue. |
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
I don't particularly care about this anymore since we are now doing it another way but I think it shouldn't be closed. |
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
🚀 feature request
Relevant Rules
All languages rules (
<language>_image
).Description
Version 0.22.0 introduced new values for stamping (
stamp:always
,stamp:never
, andstamp:use_stamp_flag
) for the basic rules via #1878. However, the language rules were not updated and are still using the old stamping values (True
andFalse
).For images generated via language rules, stamping for the Docker part can only be controlled via
--stamp
. For example,java_image
is a macro that calls rulesjava_binary
andjar_app_layer
.jar_app_layer
reusescontainer_image
. Since this call tocontainer_image
doesn't provide anystamp
argument the implementation is using the default value (stamp:use_stamp_flag
).Describe the solution you'd like
All rules from
rules_docker
use the same values for stamping.The text was updated successfully, but these errors were encountered: