Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate new values for stamping introduced in 0.22.0 to language rules #2011

Closed
joca-bt opened this issue Feb 1, 2022 · 8 comments
Closed
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not help wanted

Comments

@joca-bt
Copy link

joca-bt commented Feb 1, 2022

🚀 feature request

Relevant Rules

All languages rules (<language>_image).

Description

Version 0.22.0 introduced new values for stamping (stamp:always, stamp:never, and stamp:use_stamp_flag) for the basic rules via #1878. However, the language rules were not updated and are still using the old stamping values (True and False).

For images generated via language rules, stamping for the Docker part can only be controlled via --stamp. For example, java_image is a macro that calls rules java_binary and jar_app_layer. jar_app_layer reuses container_image. Since this call to container_image doesn't provide any stamp argument the implementation is using the default value (stamp:use_stamp_flag).

Describe the solution you'd like

All rules from rules_docker use the same values for stamping.

@joca-bt
Copy link
Author

joca-bt commented Feb 1, 2022

@alexeagle do you think this suggestion would make sense?

@alexeagle
Copy link
Collaborator

Yes, for sure, thank you for the description in the linked issue as well.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Aug 1, 2022
@joca-bt
Copy link
Author

joca-bt commented Aug 4, 2022

Dear bot, please don't close this issue.

@github-actions github-actions bot removed the Can Close? Will close in 30 days unless there is a comment indicating why not label Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Feb 2, 2023
@joca-bt
Copy link
Author

joca-bt commented Feb 2, 2023

I don't particularly care about this anymore since we are now doing it another way but I think it shouldn't be closed.

@github-actions github-actions bot removed the Can Close? Will close in 30 days unless there is a comment indicating why not label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not help wanted
Projects
None yet
Development

No branches or pull requests

2 participants