Make sure output directory for actool exists before invoking actool #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thii
force-pushed
the
actool_declare_directory
branch
from
bda63b1 to
f248143
Compare
Previously, each "actool" compile action declared an output directory but didn't create it. Instead, it relied on Bazel to create the directory before invoking the tool. With a non-remote spawn strategy, Bazel would implicitly create it for you; but with the remote spawn strategy, it is not created by the remote worker. Additionally, this was also against what was documented for `declare_directory`, which says that "You must create an action that generates the directory". This patches the "actool" wrapper to create an empty directory if one doesn't exist at the specified output path, to make it works with remote execution.
thii
force-pushed
the
actool_declare_directory
branch
from
f248143 to
57045bd
Compare
segiddins
reviewed
Sep 2, 2020
| for idx, arg in enumerate(toolargs): | ||
| if arg == "--compile": | ||
| output_dir = toolargs[idx + 1] | ||
| if not os.path.exists(output_dir): |
There was a problem hiding this comment.
could use os.makedirs(output_dir, exist_ok=True) instead of checking for existence
There was a problem hiding this comment.
Checked that but it's only available on Python ≥ 3.5.
There was a problem hiding this comment.
ugh i wish rules_python just bundled real python toolchains...
segiddins
approved these changes
Sep 2, 2020
| for idx, arg in enumerate(toolargs): | ||
| if arg == "--compile": | ||
| output_dir = toolargs[idx + 1] | ||
| if not os.path.exists(output_dir): |
There was a problem hiding this comment.
ugh i wish rules_python just bundled real python toolchains...
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
Previously, each "actool" compile action declared an output directory but didn't create it. Instead, it relied on Bazel to create the directory before invoking the tool. With a non-remote spawn strategy, Bazel would implicitly create it for you; but with the remote spawn strategy, it is not created by the remote worker. Additionally, this was also against what was documented for declare_directory, which says that "You must create an action that generates the directory". This patches the "actool" wrapper to create an empty directory if one doesn't exist at the specified output path, to make it works with remote execution. #896 RELNOTES: None PiperOrigin-RevId: 423797086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each "actool" compile action declared an output directory
but didn't create it. Instead, it relied on Bazel to create the
directory before invoking the tool. With a non-remote spawn strategy,
Bazel would implicitly create it for you; but with the remote spawn
strategy, it is not created by the remote worker.
Additionally, this was also against what was documented for
declare_directory, which says that "You must create an action thatgenerates the directory".
This patches the "actool" wrapper to create an empty directory if one
doesn't exist at the specified output path, to make it works with remote
execution.
Fixes #861.