-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use http_jar instead of rules_jvm_external to download bundletool #81
base: pre-alpha
Are you sure you want to change the base?
Conversation
So coincidentally I'm about to add another dependency to maven_install ( I also noticed that bundletool has a number of dependencies too (https://maven.google.com/web/index.html?q=bundle#com.android.tools.build:bundletool:1.6.1), e.g. dagger, autovalue, guava, proto, etc -- are these not needed to run the tool? |
Would be great to avoid using it if we can at least for externally facing tools. We've found that it's generally less performant than just using an It's also a lot easier to do overrides with http_jar(
name = "android_gmaven_r8",
sha256 = "sha goes here",
url = "http url to the jar goes here",
) Being able to do this for tools like http_jar(
name = "bundletool",
...
)
The all-jars downloaded from Github have everything compiled in that's needed to be able to execute as a CLI tool. And it's what we've been using in our builds for the past year to support app bundles. |
MODULE.bazel
Outdated
) | ||
|
||
rules_android_extensions = use_extension("//:prereqs.bzl", "rules_android_extensions") | ||
use_repo(rules_android_extensions, "bundletool_all", "py_absl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just merged this commit that uses the BCR version of py_absl.
0dab1e0
to
9791453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Slack, would you mind making a few changes?
- Rebase this PR on top of the HEAD of
main
branch - Make the PR itself a pull request into
main
through the github UI. - Revert changes that deleted Maven deps. As discussed, we want to keep Maven for internal-facing repository deps, and use http_jar() whenever possible for external-facing repo deps.
No description provided.