Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CI failures #73

Merged
merged 2 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 57 additions & 12 deletions .bazelci/postsubmit.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,67 @@
---
platforms:
ubuntu1604:
bazel: last_green
build_targets:
- "//..."
# test_targets:
# - "//..."
- "//src/..."
- "//test/..."
- "//android/..."
- "//rules/..."
- "-//src/java/com/example/sampleapp/..."
- "-//src/tools/ak/..."
- "//toolchains/..."
- "//tools/..."
test_targets:
- "//src/..."
- "//test/..."
- "-//src/tools/..."
- "-//src/java/com/example/sampleapp/..."
ubuntu1804:
bazel: last_green
build_targets:
- "//..."
# test_targets:
# - "//..."
- "//src/..."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the targets are included except //examples/..., which need to be build in a separate task, changing the directroy where their WORKSPACE file is.

The examples build works with Bazel@HEAD and using 2 extra flags:
bazel build --experimental_google_legacy_api --experimental_enable_android_migration_apis //...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we added these to the repo-level .bazelrc already.

- "//test/..."
- "//android/..."
- "//rules/..."
- "-//src/java/com/example/sampleapp/..."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has unexisting deps: "@androidsdk//com.android.support:appcompat-v7-25.0.0",
"@androidsdk//com.android.support:support-v4-25.2.0",

- "-//src/tools/ak/..."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some subdirectories are missing on github.

- "//toolchains/..."
- "//tools/..."
test_targets:
- "//src/..."
- "//test/..."
- "-//src/tools/..."
- "-//src/java/com/example/sampleapp/..."
macos:
bazel: last_green
build_targets:
- "//..."
# test_targets:
# - "//..."
- "//src/..."
- "//test/..."
- "//android/..."
- "//rules/..."
- "-//src/java/com/example/sampleapp/..."
- "-//src/tools/ak/..."
- "//toolchains/..."
- "//tools/..."
test_targets:
- "//src/..."
- "//test/..."
- "-//src/tools/..."
- "-//src/java/com/example/sampleapp/..."
windows:
bazel: last_green
build_targets:
- "//..."
# test_targets:
# - "//..."
- "//src/..."
- "//test/..."
- "//android/..."
- "//rules/..."
- "-//src/java/com/example/sampleapp/..."
- "-//src/tools/ak/..."
- "//toolchains/..."
- "//tools/..."
test_targets:
- "//src/..."
- "//test/..."
- "-//src/tools/..."
- "-//src/java/com/example/sampleapp/..."

2 changes: 1 addition & 1 deletion BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@bazel_gazelle//:def.bzl", "gazelle")
load("@gazelle//:def.bzl", "gazelle")
load("@rules_license//rules:license.bzl", "license")

package(
Expand Down
3 changes: 2 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module(
)

bazel_dep(name = "platforms", version = "0.0.5")
bazel_dep(name = "rules_license", version = "0.0.4")
bazel_dep(name = "rules_java", version = "5.3.5")
rules_java_toolchains = use_extension("@rules_java//java:extensions.bzl", "toolchains")
use_repo(rules_java_toolchains, "remote_java_tools")
Expand All @@ -17,7 +18,7 @@ register_toolchains("//toolchains/android_sdk:all")
register_toolchains("//toolchains/emulator:all")

# go-related dependency setup
bazel_dep(name = "rules_go", version = "0.34.0", repo_name = "io_bazel_rules_go")
bazel_dep(name = "rules_go", version = "0.39.1", repo_name = "io_bazel_rules_go")
bazel_dep(name = "gazelle", version = "0.28.0")
go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
Expand Down