Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R8 Proguard mappings are not propagated to the resource shrinker #133

Open
mauriciogg opened this issue Sep 11, 2023 · 1 comment · May be fixed by #149
Open

R8 Proguard mappings are not propagated to the resource shrinker #133

mauriciogg opened this issue Sep 11, 2023 · 1 comment · May be fixed by #149

Comments

@mauriciogg
Copy link
Contributor

Currently there is no way to pass proguard mappings to the resource shrinker. Without it a bunch of resource that should that should be kept are removed instead. This is currently not supported directly by the shrinker tool. I've filed a feature request on android requesting support, but if the feature is not accepted we will need to implement our own wrapper.
@mauriciogg mauriciogg linked a pull request Sep 21, 2023 that will close this issue
Open
@mauriciogg
Copy link
Contributor Author

I've added a implementation for the resource shrinker cli that accepts proguard mappings here #149. At least in our builds it does not really seems to have any effect though. Additional resources that were being stripped in our builds due to the use of precise shinking option not because of the missing proguard mapping, so im not really sure this is entirely necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept proguard mapping file in resource shrinker mauriciogg/rules_android
1 participant
@mauriciogg