Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REv3 idea: Make is_topologically_sorted the default, and eliminate tag bytes #232

Open
EdSchouten opened this issue Oct 23, 2022 · 0 comments

Comments

@EdSchouten
Copy link
Collaborator

In #229 and #230 we added a new is_topologically_sorted flag that can be used by workers to indicate that Tree objects are topologically sorted, making it easier to process them. It also simplified the wire format of Tree objects slightly, making it easier to parse them without using a Protobuf library.

  1. This proposal is to make this option the default, requiring that all workers generate such Trees.
  2. It proposes that we remove the tag bytes from the records, as they no longer serve any real purpose. It is already implied that the root directory is the first to be stored.
  3. As (2) causes the encoding to differ from message Tree, we should then remove this message entirely. There are no other parts of the protocol where it is used.

Note that this is just a minor cleanup. If it turns out we manage to solve issues like #170, we can close this as being irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant