Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tags for minor versions #222

Open
jmillikin opened this issue Apr 18, 2022 · 0 comments
Open

Git tags for minor versions #222

jmillikin opened this issue Apr 18, 2022 · 0 comments

Comments

@jmillikin
Copy link
Contributor

There's currently two Git tags defined in bazelbuild/remote-apis:

  • Tag v2.0.0 is commit e77c4eb and is (hopefully) what implementations mean by SemVer { major: 2 }.
  • Tag 4ac0011 is commit 4ac0011 and is of unknown meaning.

The comments in remote_execution.proto refer to changes in minor versions v2.1, v2.2, and v2.3 which are not tagged. This makes it difficult to determine which behavior a conforming implementation should have at each version.

Given that there's now multiple APIs specified, and multiple versions of the Remote Execution API, would it be possible to add additional tags? For example:

  • execution/v2.0, execution/v2.1, execution/v2.2, and execution/v2.3 that can be used as stable references for a given version of remote_execution.proto
  • asset/v1.0 and logstream/v1.0 for similar purposes in the remote_asset.proto and remote_logstream.proto files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant