Windows, launcher: rename GetEscapedArgument #7395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step: implement correct escaping semantics for subprocesses created with CreateProcessW. See bazelbuild#7072
|
/cc @meteorcloudy -- FYI. |
meteorcloudy
approved these changes
Feb 12, 2019
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this pull request
Feb 12, 2019
Add a unit test to assert that: - WindowsEscapeArg escapes flags as expected - When we pass a WindowsEscapeArg-escaped flag to CreateProcessW, the subprocess receives the original flag. This is a follow-up to bazelbuild#7395 Next I'll fix WindowsEscapeArg to correctly escape arguments. See bazelbuild#7072
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this pull request
Feb 13, 2019
Add a unit test to assert that: - WindowsEscapeArg escapes flags as expected - When we pass a WindowsEscapeArg-escaped flag to CreateProcessW, the subprocess receives the original flag. This is a follow-up to bazelbuild#7395 Next I'll fix WindowsEscapeArg to correctly escape arguments. See bazelbuild#7072
bazel-io
pushed a commit
that referenced
this pull request
Feb 13, 2019
Add a unit test to assert that: - WindowsEscapeArg escapes flags as expected - When we pass a WindowsEscapeArg-escaped flag to CreateProcessW, the subprocess receives the original flag. This is a follow-up to #7395 Next I'll fix WindowsEscapeArg to correctly escape arguments. See #7072 Closes #7402. PiperOrigin-RevId: 233703690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce BashEscapeArg and WindowsEscapeArg that
just wrap GetEscapedArgument for now.
The Bash launcher needs to escape the arguments
Bash style (using BashEscapeArg) while the Java
and Python launchers need to escape them Windows
style (using WindowsEscapeArg).
(The code is now incorrectly escaping everything
with Bash syntax, i.e. GetEscapedArgument.)
Next step: implement correct escaping semantics
for subprocesses created with CreateProcessW.
See #7072