Add new NDK rules to the NDK docs #18523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsauer
requested review from
gregestren,
philomathing and
fweikert
as code owners
github-actions
bot
added
awaiting-review
meteorcloudy
requested review from
ted-xie and
ahumesky
and removed request for
gregestren,
fweikert and
philomathing
ahumesky
approved these changes
Jul 21, 2023
|
Thanks so much for the approval, Alex! |
|
Hi @ahumesky, Since I can see that this PR has been approved, please let me know whether I should proceed with importing it.Thanks ! |
ahumesky
added
awaiting-PR-merge
|
Sorry, forgot to relabel -- ready to import, thanks! |
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi wonderful Bazelers,
I'd happened to notice that the new NDK rules weren't referenced from the NDK docs, so I thought I'd toss up a quick change to help new users find their way.
Thanks for your consideration! Feel free (of course) to edit or push a different change if you'd prefer something else. (Was trying to strike a balance between the new rule being in their early stages and the old rule no longer being updated and not working for the past few years of NDKs. See #12889 for more context.)
Thanks,
Chris
(ex-Googler, compile_commands_extractor author, rules_boost collaborator, etc.)