Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported symbols from cc_binary shared lib change from 0.29.1 to 1.0.0rc3 #9439

Closed
wesleyw72 opened this issue Sep 25, 2019 · 4 comments
Closed
Assignees
Labels

Comments

@wesleyw72
Copy link

I am building a shared library using cc_binary which depends on some cc_library targets (which in turn depend on other cc_library targets). When building this target in 0.29.1 the shared library contains the symbols from a cc_library it depends on (of the form cc_binary -> cc_lib -> cc_lib -> cc_lib with symbols). I upgraded to 1.0.0rc3 and rebuilt the same target, and the symbol is now missing from the shared library.

What's changed to cause this?

OS:

MacOS Mojave 10.14.6

@wesleyw72
Copy link
Author

Can confirm this on Ubuntu 18.04 also

@dslomov
Copy link
Contributor

dslomov commented Sep 26, 2019

/cc @hlopko @oquenchil I bet this is one of our incompatible flags - could you investigate?

@hlopko
Copy link
Member

hlopko commented Sep 26, 2019

And I bet it's #7362, can you try unflipping it and see if it helps?

@hlopko hlopko self-assigned this Sep 26, 2019
@wesleyw72
Copy link
Author

I think that's it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants