Parse Starlark files as raw bytes for Bzlmod #24217
Open
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
|
This needs #24010 to get its test to pass. |
|
@bazel-io fork 8.0.0 |
fmeum
force-pushed
the
23859-unicode-bzlmod
branch
from
5b5f9a5
to
31f0271
Compare
|
Ready for review now. @tjgq FYI, this is the other Unicode-related PR I am planning to get into 8.0.0. If you see anything else that looks incompatible, please let me know. |
|
Turns out that there is an interesting failure, switching back to draft. |
fmeum
force-pushed
the
23859-unicode-bzlmod
branch
7 times, most recently
from
e8c1ed0
to
ae182a1
Compare
As long as Bazel internally represents strings as raw bytes "encoded" in Latin-1, the same must be true for all Starlark files that may contain e.g. file system paths.
fmeum
force-pushed
the
23859-unicode-bzlmod
branch
from
165f03b
to
a68c20e
Compare
|
@Wyverald CI should be green now, I just had to fix some issues in the Python test setup code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as Bazel internally represents strings as raw bytes "encoded" in Latin-1, the same must be true for all Starlark files that may contain file system paths.
Also includes changes to the Python test setup:
ScratchFilenow always writes files as UTF-8RunProgramencodes and decodes stdin/stderr/stdout as UTF-8downloadno longer leaks a file