Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visible query operator for Macro-Aware Visibility #23856

Open
brandjon opened this issue Oct 3, 2024 · 1 comment
Open

Fix visible query operator for Macro-Aware Visibility #23856

brandjon opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob type: bug

Comments

@brandjon
Copy link
Member

brandjon commented Oct 3, 2024

@bazel-io flag 8.0.0
This is likely something we can cherrypick into 8.0 in October.


The visible operator for bazel query commands has a separate implementation from Bazel's actual visibility check done in the analysis phase. We have not yet updated that implementation to take into account the new Macro-Aware Visibility model. The consequence is that visible(...) may return incorrect results for consuming targets created inside symbolic macros.

@brandjon brandjon added type: bug P1 I'll work on this now. (Assignee required) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob labels Oct 3, 2024
@brandjon
Copy link
Member Author

@bazel-io fork 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob type: bug
Projects
None yet
Development

No branches or pull requests

2 participants