Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.2.0] default_java_toolchain.bzl cherry-picks to fix regression #18223

Closed
keertk opened this issue Apr 26, 2023 · 1 comment
Closed

[6.2.0] default_java_toolchain.bzl cherry-picks to fix regression #18223

keertk opened this issue Apr 26, 2023 · 1 comment
Milestone
6.2.0 release blo...

Comments

@keertk
Copy link
Member

keertk commented Apr 26, 2023 •
edited
Loading

Bazel failure in 6.2.0rc1 that doesn't appear at HEAD:

src/tools/android/java/com/google/devtools/build/android/desugar/scan/PrefixReferenceScanner.java:306: error: [LenientFormatStringValidation] Expected 0 positional arguments, but saw 1
        checkArgument(
                     ^
    (see https://errorprone.info/bugpattern/LenientFormatStringValidation)
  Did you mean '"Unexpected constant:  (%s)",'?

Commits to cherry-pick to fix this:
3b57894 Disable 'IgnoredPureGetter'
8d9a06e Make EmptyTopLevelDeclaration a warning
33a3b01 Make LenientFormatStringValidation a warning
e80ca15 Make ReturnMissingNullable a warning
abea37b Redirect JVM warnings to stderr in general.

cc @meteorcloudy @comius
@keertk keertk added this to the 6.2.0 release blockers milestone Apr 26, 2023
@keertk
Copy link
Member Author

keertk commented Apr 26, 2023

Cherry-picked in #18225

@keertk keertk closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0 release blockers
Development

No branches or pull requests
1 participant
@keertk