Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--per_file_copt requires argument changes with bzlmod #17132

Closed
keith opened this issue Jan 4, 2023 · 3 comments
Closed

--per_file_copt requires argument changes with bzlmod #17132

keith opened this issue Jan 4, 2023 · 3 comments
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@keith
Copy link
Member

keith commented Jan 4, 2023

If you passed something like --per_file_copt=external/com_google_protobuf/.*.cpp@-Wno-type-limits, and try to move to bzlmod, the flag no longer works because the repository name is taken literally and doesn't contain the version info. In this case you likely need something like external/protobuf~.*/, but ideally your existing flags would keep working and this wouldn't be taken so literally. I'm sure there are other flags with a similar issue

@sgowroji sgowroji added type: bug team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged area-Bzlmod Bzlmod-specific PRs, issues, and feature requests labels Jan 4, 2023
@Wyverald Wyverald added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed type: bug untriaged labels Jan 17, 2023
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 7 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler".

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 17, 2023
@brentleyjones
Copy link
Contributor

cc @Wyverald

(And not stale)

@sgowroji sgowroji removed the stale Issues or PRs that are stale (no activity for 30 days) label Feb 17, 2023
@Wyverald
Copy link
Member

I believe this is just a dupe of #15553. Let me know if that's not true!

@Wyverald Wyverald closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants