Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package contains malformed fields #15201

Closed
aiuto opened this issue Apr 8, 2022 · 5 comments
Closed

Debian package contains malformed fields #15201

aiuto opened this issue Apr 8, 2022 · 5 comments
Assignees
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@aiuto
Copy link
Contributor

aiuto commented Apr 8, 2022

Description of the bug:

The debian package contains some fields which are wrapped to multiple lines instead of a long single line. This violates the specification and can cause other tools to fail.
The trivial fix is to update to rules_pkg release 0.7.0 or greater.
Please also backport to the 5.x release branch.

@smu-ggl

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No need to reproduce

Which operating system are you running Bazel on?

linux

What is the output of bazel info release?

5.x, head

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

N/A

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

N/A

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

PR to fix for head is being tested right now.

@aiuto aiuto added P1 I'll work on this now. (Assignee required) area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling labels Apr 8, 2022
@aiuto aiuto self-assigned this Apr 8, 2022
@sgowroji sgowroji added untriaged team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug and removed untriaged labels Apr 20, 2022
@meteorcloudy
Copy link
Member

@aiuto Are you actively working on this, should this be P1?

@aiuto
Copy link
Contributor Author

aiuto commented Jul 12, 2022

This is not a P1 unless other people really need a 5.x backport. I'll change it.
For everyone else, we can wait for the fix in rules_pkg 0.8.x and then update bazel.
That should be easy in the 6.x release timeframe.

@aiuto aiuto added P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels Jul 12, 2022
@aiuto
Copy link
Contributor Author

aiuto commented Aug 4, 2022

Moving back to P1 so I get nag mail.

@aiuto aiuto added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Aug 4, 2022
@meteorcloudy
Copy link
Member

@aiuto Do we really want to keep this as P1?

@aiuto
Copy link
Contributor Author

aiuto commented Mar 28, 2023

Not a P1 at all.
I think this is fixed since we updated to rules_pkg 0.8.0. Since we don't have fixed by not verified, I'm going to close now and someone can add to the bug if the issues surfaces at head.

@aiuto aiuto added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P1 I'll work on this now. (Assignee required) P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) labels Mar 28, 2023
@aiuto aiuto closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Development

No branches or pull requests

3 participants