Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Actions Proto Contains grep-includes.sh as though it were a C++ Header #12858

Closed
cpsauer opened this issue Jan 20, 2021 · 2 comments
Closed
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Jan 20, 2021

Description of the problem:

The sources_and_headers attribute of the @bazel_tools//src/main/protobuf:extra_actions_base_proto provided to CppCompile and ObjcCompile (mnemonic) actions contains 'external/bazel_tools/tools/cpp/grep-includes.sh'. This feels like it has to be a mistake, since that's an unimplemented tool, not a c-language family file.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

As in #12852, I think the fastest way to do that would be to grab Kythe's implementation of an extractor (https://github.com/kythe/kythe/blob/master/kythe/cxx/extractor/README.md) and examine the extra_actions_base_proto's sources_and_headers attribute.

What operating system are you running Bazel on?

macOS 11

What's the output of bazel info release?

3.7.2

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

This is a private repo for now.

Have you found anything relevant by searching the web?

Yep. Results of learnings above.

@oquenchil oquenchil added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Feb 11, 2021
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 28, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: bug
Projects
None yet
Development

No branches or pull requests

3 participants