Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump outdated third_party/android_common/com.android.tools_sdk-common_25.0.0.jar to recent release #11448

Closed
davido opened this issue May 20, 2020 · 2 comments
Assignees
Labels
team-Android Issues for Android team untriaged

Comments

@davido
Copy link
Contributor

davido commented May 20, 2020

This major Android dependency is totally outdated. Currently used version 25.0.0 in Bazel seems to be from April 2016. The current version is provided by Google and is from May 2020: 27.1.0-alpha09:

https://maven.google.com/com/android/tools/sdklib/27.1.0-alpha09/sdklib-27.1.0-alpha09.jar

Recent attempts to bump Guava dependency in Bazel are failing because of the collision of recent Guava releases and Guava version used in tools_sdk-common_25.0.0.jar.

See these discusions: here and here.

This PR and this PR are failing Android tests because of Guava version collision.

//CC @ahumesky @jin @tetromino

@aiuto aiuto added team-Android Issues for Android team area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling untriaged and removed area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling labels May 21, 2020
@aiuto
Copy link
Contributor

aiuto commented May 21, 2020

There are 3 or 5 issues and PRs related to this, errorprone, and guava which all seem to to be related and fixable together. Can someone on the Android team answer decided a priority for dealing with it. If it is low priority for us, can we outline an acceptable plan for someone else to fix it.

@ahumesky
Copy link
Contributor

ahumesky commented Dec 3, 2020

Updating this dependency is quite tricky, and the long term plan is to separate this code from Bazel all together, but that will take some time. #10394 and #11426 were unblocked by patching this dependency, so I'll close this

@ahumesky ahumesky closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team untriaged
Projects
None yet
Development

No branches or pull requests

4 participants