Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give finer control over local/transitive defines in C++ rules #11369

Closed
oquenchil opened this issue May 12, 2020 · 1 comment
Closed

Give finer control over local/transitive defines in C++ rules #11369

oquenchil opened this issue May 12, 2020 · 1 comment
Labels
help wanted Someone outside the Bazel team could own this P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@oquenchil
Copy link
Contributor

oquenchil commented May 12, 2020 •
edited
Loading

There should be better support for defines in C++ removing logic which is platform-dependent and allowing to specify whether it should only be used locally or be propagated.

Related but for includes #6790

We should follow the design process for this: https://bazel.build/designs/
@oquenchil oquenchil added type: feature request team-Rules-CPP Issues for C++ rules help wanted Someone outside the Bazel team could own this labels May 12, 2020
@oquenchil oquenchil mentioned this issue May 12, 2020
Closed
@oquenchil oquenchil changed the title Give finer control over local/transitive includes and defines in C++ rules Give finer control over local/transitive defines in C++ rules May 12, 2020
@oquenchil oquenchil added the P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) label May 12, 2020
@oquenchil
Copy link
Contributor Author

Support for this was actually added in August last year. One can use the attribute local_defines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Someone outside the Bazel team could own this P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oquenchil