Flip the --incompatible_disallow_native_in_build_file flag

Fixes #7513 RELNOTES[INC]: The "native" module is no longer available in BUILD files, all its members can be accessed directly as global symbols. This can be temporarily reverted by providing --incompatible_disallow_native_in_build_file=false as a flag to Blaze. PiperOrigin-RevId: 249508813
bazelbuild · May 22, 2019 · 8241d27 · 8241d27
1 parent 82df64d
commit 8241d27
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -304,7 +304,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
 
   @Option(
       name = "incompatible_disallow_native_in_build_file",
-      defaultValue = "false",
+      defaultValue = "true",
       documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
       effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
       metadataTags = {

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -233,7 +233,7 @@ public static Builder builderWithDefaults() {
           .incompatibleDisallowLegacyJavaProvider(false)
           .incompatibleDisallowLegacyJavaInfo(false)
           .incompatibleDisallowLoadLabelsToCrossPackageBoundaries(true)
-          .incompatibleDisallowNativeInBuildFile(false)
+          .incompatibleDisallowNativeInBuildFile(true)
           .incompatibleDisallowOldOctalNotation(true)
           .incompatibleDisallowOldStyleArgsAdd(true)
           .incompatibleDisallowRuleExecutionPlatformConstraintsAllowed(false)

diff --git a/src/test/shell/bazel/local_repository_test.sh b/src/test/shell/bazel/local_repository_test.sh
@@ -904,7 +904,7 @@ genrule(
   name = 'b',
   srcs = [],
   outs = ['bo'],
-  cmd = 'echo ' + native.repository_name() + ' ' + native.package_name() + ' > $@')
+  cmd = 'echo ' + repository_name() + ' ' + package_name() + ' > $@')
 EOF
 
   cat > WORKSPACE <<EOF