From 02055e6b18318a526d5cd7be73654c0da5185362 Mon Sep 17 00:00:00 2001
From: Fabian Meumertzheim <fabian@meumertzhe.im>
Date: Wed, 24 Jan 2024 21:48:40 +0100
Subject: [PATCH] Address review comments

---
 src/main/java/net/starlark/java/eval/BuiltinFunction.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/main/java/net/starlark/java/eval/BuiltinFunction.java b/src/main/java/net/starlark/java/eval/BuiltinFunction.java
index d6b956a90e2c47..80f733c6f9a8a5 100644
--- a/src/main/java/net/starlark/java/eval/BuiltinFunction.java
+++ b/src/main/java/net/starlark/java/eval/BuiltinFunction.java
@@ -157,6 +157,9 @@ private Object[] getArgumentVector(
     ParamDescriptor[] parameters = desc.getParameters();
 
     // Fast case: reuse positional as Java argument vector
+    // StringModule methods, which are treated specially below, will never match this case since
+    // their "self" parameter is restricted to String and thus
+    // getPositionalsCanBeJavaArgumentVector() is false.
     if (desc.getPositionalsCanBeJavaArgumentVector()
         && positional.length == parameters.length
         && named.length == 0) {