Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [email protected] #430

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

seh
Copy link
Contributor

@seh seh commented Feb 8, 2023

Impound Bazel rules for the CUE language's cue tool defined in the seh/rules_cue GitHub repository.

Note that the source repository started as a fork of the tnarg/rules_cue repository, but it hasn't shared any remaining code for a long while. On 10 January 2023 in the "CUE" Slack workspace, I asked @tnarg whether he intends to register his rules_cue repository with the BCR. Today he noted that he's no longer using CUE actively, and offered to advocate for my fork going forward.

@seh seh force-pushed the impound-rules_cue-module branch from 9416731 to 85c9abf Compare February 8, 2023 18:33
@tnarg
Copy link

tnarg commented Feb 8, 2023

+1 for @seh's fork becoming "official"

@seh seh force-pushed the impound-rules_cue-module branch 3 times, most recently from 4eabd00 to aea467d Compare February 10, 2023 16:05
@fmeum fmeum enabled auto-merge (squash) February 10, 2023 16:41
@seh
Copy link
Contributor Author

seh commented Feb 10, 2023

There's some problem with downloading the built cue tool as a release artifact for some of the platforms. I'll investigate that next.

auto-merge was automatically disabled February 10, 2023 18:28

Head branch was pushed to by a user without write access

@seh seh force-pushed the impound-rules_cue-module branch from aea467d to 93e9aad Compare February 10, 2023 18:28
@seh
Copy link
Contributor Author

seh commented Feb 10, 2023

There's some problem with downloading the built cue tool as a release artifact for some of the platforms.

The release artifacts for the cue tool built for Windows are ZIP archives. The code now accommodates that case (again).

@fmeum fmeum enabled auto-merge (squash) February 10, 2023 19:10
Impound Bazel rules for the CUE language's "cue" tool defined in the
"seh/rules_cue" GitHub repository.

Withdraw promised support for Windows until we resolve #17487.
auto-merge was automatically disabled February 14, 2023 19:27

Head branch was pushed to by a user without write access

@seh seh force-pushed the impound-rules_cue-module branch from 93e9aad to 203f55a Compare February 14, 2023 19:27
@seh
Copy link
Contributor Author

seh commented Feb 14, 2023

Repeating the comment I added in the presubmit.yml file, some valid invocations of the cue tool can't succeed (e.g. use of the "path" and "expression" rules attributes) until we resolve or find a reliable workaround for bazelbuild/bazel#17487. Until then, withdraw promised support for using this module on Windows.

@Wyverald Wyverald merged commit 4136d77 into bazelbuild:main Feb 15, 2023
@seh seh deleted the impound-rules_cue-module branch February 15, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants