Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc-java 1.68.1 #3448

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add grpc-java 1.68.1 #3448

wants to merge 4 commits into from

Conversation

mortenmj
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (grpc-java) have been updated in this PR. Please review the changes.

@mortenmj
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 18, 2024
fmeum
fmeum previously approved these changes Dec 18, 2024
View reviewed changes
modules/grpc-java/1.68.1/presubmit.yml Outdated Show resolved Hide resolved
modules/grpc-java/1.68.1/MODULE.bazel
"com.google.guava:guava:33.2.1-android",
"com.google.j2objc:j2objc-annotations:3.0.0",
"com.google.re2j:re2j:1.7",
"com.google.truth:truth:1.4.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure that's preexisting, but leaking test deps into the shared maven namespace isn't ideal. Not sure what the Bzlmod situation is upstream though.

@bazel-io bazel-io dismissed fmeum’s stale review December 18, 2024 12:42

Require module maintainers' approval for newly pushed changes.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mortenmj @bazel-io @fmeum @meteorcloudy