Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3435

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[email protected] #3435

merged 1 commit into from
Dec 17, 2024

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Dec 16, 2024

Add module dependencies on rules_cc and rules_license.
Use cc_library from rules_cc instead of native.
Add license annotations.
Test with Bazel 8.x and rolling (in addition to 7.x) and ubuntu2404.

@bazel-io
Copy link
Member

Hello @Vertexwahn, modules you maintain (fmt) have been updated in this PR. Please review the changes.

Add module dependencies on rules_cc and rules_license.
Use cc_library from rules_cc instead of native.
Add license annotations.
Test with Bazel 8.x and rolling (in addition to 7.x) and ubuntu2404.
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum enabled auto-merge (squash) December 16, 2024 20:44
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 17, 2024
@fmeum fmeum merged commit 4a94675 into bazelbuild:main Dec 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants