Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental option to generate dependencies labels against an external repository #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hborawski
Copy link

Rather than have all dependency labels be absolute (//Pods/SomePod) this experimental option generates labels to point to an external repository, allowing a more flexible folder structure, since your Pods folder doesn't need to be in the root

//Pods/SomePod -> @Pods//SomePod

This obviously needs to work in conjunction with a repository rule, which I have a basic implementation of that works, if theres a place I can PR that to, I'd be happy to do that

just trying to utilize this plugin for my situation without needing to maintain a fork

The project i'm working on is a multi platform mono-repo, so we want to be able to isolate the ios files into an ios folder, rather than polluting the root of the repo with pod related files

@hborawski
Copy link
Author

Build seems to have failed xcode-select, unrelated to my changes

@chenxiao0228
Copy link
Collaborator

@hborawski Thanks for the PR!

GitHub upgraded the Mac hosts for running actions, Xcode 12.2 is not valid any more. I'll look into it soon.

@justinseanmartin
Copy link
Collaborator

There is another PR up in which @gyfelton removes that check. I think once that lands we can rebase on top of that.

@chenxiao0228
Copy link
Collaborator

@hborawski please merge the main branch, it should have been fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants