Filter unmatching configuration-specific dependencies #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelliJ seems to implicitly do this on save.
Bazel 6 got the ability to report configuration transitions: bazelbuild/bazel#15038 This allows us to stop over-estimating affected targets when dependencies exist in platforms other than the current one.
illicitonion
commented
Mar 24, 2023
.../integration/java/com/github/bazel_contrib/target_determinator/integration/TestdataRepo.java
Outdated
Show resolved
Hide resolved
|
The contents of assorted commits being referred to can be found in bazel-contrib/target-determinator-testdata#4 |
sitaktif
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 6 got the ability to report configuration transitions:
bazelbuild/bazel#15038
This allows us to stop over-estimating affected targets when
dependencies exist in platforms other than the current one.