From a80750dc2e0ec8e52fbffdf2601671bc21870fb8 Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Fri, 31 May 2019 10:38:05 -0700 Subject: [PATCH] Update examples/vendored_node to reflect best practice of specifying node version The docs for node_repositories() reflect this now and the reason is that node_repositories() will set node options depending on version used --- examples/vendored_node/WORKSPACE | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/vendored_node/WORKSPACE b/examples/vendored_node/WORKSPACE index caaad37528..a35b484474 100644 --- a/examples/vendored_node/WORKSPACE +++ b/examples/vendored_node/WORKSPACE @@ -31,6 +31,7 @@ local_repository( load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories", "npm_install", "yarn_install") node_repositories( + node_version = "10.12.0", vendored_node = "@examples_vendored_node//:node-v10.12.0-linux-x64", vendored_yarn = "@examples_vendored_node//:yarn-v1.10.0", )