Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel_skylib dependency to 0.8.0 #657

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

laszlocsomor
Copy link
Contributor

@laszlocsomor laszlocsomor commented Apr 5, 2019

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

rules_nodejs depends on bazel_skylib 0.6.0

What is the new behavior?

rules_nodejs depends on bazel_skylib 0.8.0

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@laszlocsomor laszlocsomor changed the title WIP: Update bazel_skylib dependency to 0.8.0 Update bazel_skylib dependency to 0.8.0 Apr 5, 2019
package.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle force-pushed the update-skylib-0.8.0 branch from e6a9c1c to bfaceed Compare April 5, 2019 18:31
@alexeagle
Copy link
Collaborator

I confirmed there are no changes in https://raw.githubusercontent.com/bazelbuild/bazel-skylib/0.8.0/lib/paths.bzl from what we've vendored

@alexeagle alexeagle merged commit 1a549f6 into bazel-contrib:master Apr 5, 2019
@laszlocsomor laszlocsomor deleted the update-skylib-0.8.0 branch April 8, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants