Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recommended way to make changes to npm dependencies #3514

Closed
reddaly opened this issue Jul 29, 2022 · 2 comments
Closed

Document recommended way to make changes to npm dependencies #3514

reddaly opened this issue Jul 29, 2022 · 2 comments
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@reddaly
Copy link

reddaly commented Jul 29, 2022

I want to fix this bug in ts-protoc-gen, which is used by rules_protoc_gen: https://github.com/improbable-eng/ts-protoc-gen.

What's the typical workflow for developing changes to an NPM dependency using rules_nodejs? I don't see this documented.

It doesn't help my case that I don't use npm very much. I mainly work in Google's monorepo where modifying dependencies works just like modifying my team's code.... I just edit it.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jan 29, 2023
@github-actions
Copy link

This issue was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

No branches or pull requests

1 participant