Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply the yarn binary as attribute to yarn_install #3175

Closed
alexeagle opened this issue Dec 23, 2021 · 1 comment
Closed

supply the yarn binary as attribute to yarn_install #3175

alexeagle opened this issue Dec 23, 2021 · 1 comment

Comments

@alexeagle
Copy link
Collaborator

Currently we have a yarn version by virtue of the the yarn_version attribute in node_repositories. However this is not toolchain-aware, and is awkwardly stored for subsequent calls to yarn_install.

Yarn is just a javascript program without platform dependencies, so it should just be provided as a label to the yarn_install rule.
@alexeagle
Copy link
Collaborator Author

Fixed by #3230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeagle