Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select in toolchains causes eager fetch for all platforms #3124

Closed
alexeagle opened this issue Dec 7, 2021 · 2 comments
Closed

select in toolchains causes eager fetch for all platforms #3124

alexeagle opened this issue Dec 7, 2021 · 2 comments
Assignees
@alexeagle
Milestone
5.0

Comments

@alexeagle
Copy link
Collaborator

This should be removed:

https://github.com/bazelbuild/rules_nodejs/blob/stable/toolchains/node/BUILD.bazel#L94-L125

we have a resolved_toolchain mechanism in 5.x instead.
@alexeagle alexeagle added this to the 5.0 milestone Dec 7, 2021
@alexeagle alexeagle self-assigned this Dec 7, 2021
@alexeagle alexeagle mentioned this issue Dec 9, 2021
Merged
12 tasks
@mattem
Copy link
Collaborator

mattem commented Jan 4, 2022

@alexeagle believes this is fixed now

@mattem mattem closed this as completed Jan 4, 2022
@mattem
Copy link
Collaborator

mattem commented Jan 4, 2022

Closed via #3172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@alexeagle @mattem