Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasmine_node_test cannot find c8 even though @npm//c8 is passed in deps #2736

Closed
dylanShark opened this issue Jun 2, 2021 · 2 comments
Closed
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@dylanShark
Copy link

🐞 bug report

Affected Rule

The issue is caused by the rule:

jasmine_node_test

Is this a regression?

Not sure

Description

Hi team, we are currently using rules_nodejs 3.4.2. We try to invoke jasmine_node_test like the following:

jasmine_node_test(
    name = "some_test",
    srcs = [
        ":js_src",
    ],
    deps = ["@npm//c8",]
)        

and when running bazel coverage on this target, we get error ERROR: c8 npm package is required for bazel coverage. I also tried putting "@npm//c8", in srcs but it didn't work either. I thought this was fixed in #2100 which should have been included in 3.4.2, could someone please take a look?

🔬 Minimal Reproduction

🔥 Exception or Error





ERROR: c8 npm package is required for bazel coverage

🌍 Your Environment

Operating System:

  
macos 10.15.7
  

Output of bazel version:

  
Build label: 3.7.1
  

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

  
3.4.2
  

Anything else relevant?

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Sep 1, 2021
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

No branches or pull requests

1 participant