Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS 404 on Bazel mirror (node-v14.15.3-linux-x64.tar.xz) #2406

Closed
achew22 opened this issue Jan 17, 2021 · 2 comments · Fixed by #2408
Closed

NodeJS 404 on Bazel mirror (node-v14.15.3-linux-x64.tar.xz) #2406

achew22 opened this issue Jan 17, 2021 · 2 comments · Fixed by #2408
Assignees
Labels

Comments

@achew22
Copy link
Member

achew22 commented Jan 17, 2021

🐞 bug report

Affected Rule

load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")

node_repositories(
    node_version = "14.15.3",
    yarn_version = "1.22.4",
)

Is this a regression?

Not sure. Since this is a non-fatal error, I don't know if it's new since we upgraded about 20 days ago. It has been in all the CI runs that I'm checked in our run history.

Description

A clear and concise description of the problem...

It's possible that I just noticed this (it's a warning after all) now and that it's successfully falling back to an alternative download. I hypothesize that the rules_nodejs releaser doesn't upload all the node versions to gcs for mirroring. If that's the case then it might be worth noting that the selected version of nodejs by the caller is not one that is mirrored on GCS and removing it from the alternative download list.

🔬 Minimal Reproduction

WORKSPACE:

http_archive(
    name = "build_bazel_rules_nodejs",
    sha256 = "6142e9586162b179fdd570a55e50d1332e7d9c030efd853453438d607569721d",
    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/3.0.0/rules_nodejs-3.0.0.tar.gz"],
)

# Check the bazel version and download npm dependencies
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")

node_repositories(
    node_version = "14.15.3",
    yarn_version = "1.22.4",
)

🔥 Exception or Error


WARNING: Download from https://mirror.bazel.build/nodejs.org/dist/v14.15.3/node-v14.15.3-linux-x64.tar.xz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found

🌍 Your Environment

Operating System:

  
$ uname -a
Linux devbox 5.4.0-1032-gcp #34-Ubuntu SMP Wed Dec 9 17:23:16 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  

Output of bazel version:

  
$ bazel version
Starting local Bazel server and connecting to it...
Build label: 3.7.2
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Dec 17 16:57:23 2020 (1608224243)
Build timestamp: 1608224243
Build timestamp as int: 1608224243
  

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

  
http_archive(
    name = "build_bazel_rules_nodejs",
    sha256 = "6142e9586162b179fdd570a55e50d1332e7d9c030efd853453438d607569721d",
    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/3.0.0/rules_nodejs-3.0.0.tar.gz"],
)
  

Anything else relevant?

Nope. Thanks so much!

@mattem
Copy link
Collaborator

mattem commented Jan 18, 2021

Thanks for the report, we'll have to find someone from Google that has access to updating the mirror, as I assume it's controlled by them still.

@alexeagle do you know who would be a contact point here?

@mattem
Copy link
Collaborator

mattem commented Jan 19, 2021

We discussed this today in the sync meeting and we don't think it should be on Bazel or the Bazel team to mirror NodeJS releases.
We decided to change our default URLs to stop using mirror.bazel.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants