You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it makes sense to have ts_compiler/ng_compiler rule as I suggested. It allows separate configuration/fiddling with the compiler and associated runtime libs. ts_compiler would be TypeScript compiler (typescript), runtime library (tslib), and perhaps options
ts_compiler(
name = "tsc",
compiler = "@npm//typescript",
runtime_deps = ["@npm//tslib"],
options = { "strict": True } # defaults
)
ts_library(
name = "example_ts"
compiler = ":tsc", # default to some bind()
srcs = glob(["**/*.ts"])
)
ng_compiler(
name = "ngc",
compiler = "@npm//angular-compiler-cli",
runtime_deps = ["@npm//angular-core", "@npm//tslib"],
options = { "strict": True } # defaults
)
ng_library(
name = "example_ng"
compiler = ":ngc", # default to some bind()
srcs = glob(["**/*.ts"])
assets = glob(["**/*.html", "**/*.css"])
)
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!
Broken out from #2038. @pauldraper suggests:
The text was updated successfully, but these errors were encountered: