Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker assumes node_modules goes in workspace root #1373

Closed
alexeagle opened this issue Nov 21, 2019 · 3 comments
Closed

linker assumes node_modules goes in workspace root #1373

alexeagle opened this issue Nov 21, 2019 · 3 comments
Labels
bug Can Close? We will close this in 30 days if there is no further activity

Comments

@alexeagle
Copy link
Collaborator

in #1332 @soldair introduces a nested package.json which is npm_install'ed in the workspace

managed_directories = {
        "@npm": ["node_modules"],
        "@npm_node_patches": ["packages/node-patches/node_modules"],
    },

When running a node program using this @npm_node_patches workspace, the linker ought to lay out $PWD/packages/node-patches/node_modules but they go in $PWD/node_modules instead.

@alexeagle alexeagle added the bug label Nov 21, 2019
@excavador
Copy link

Do you have any estimate to fix?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Sep 16, 2020
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

No branches or pull requests

2 participants