Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update to rules_go to 0.18.7 or later #1001

Closed
alexeagle opened this issue Aug 12, 2019 · 3 comments
Closed

Cannot update to rules_go to 0.18.7 or later #1001

alexeagle opened this issue Aug 12, 2019 · 3 comments
Labels
cleanup Tech debt, resolving it improves our own velocity

Comments

@alexeagle
Copy link
Collaborator

alexeagle commented Aug 12, 2019

Looks like a change in rules_go
bazel-contrib/rules_go@4442d82
made Runfiles resolution no longer work the way we rely on in ts_devserver.

error looks like https://circleci.com/gh/bazelbuild/rules_nodejs/27670

Could not find runfile build_bazel_rules_nodejs/packages/protractor/test/protractor-2/_devserver_launcher.amd_names_shim.js, got error Runfile build_bazel_rules_nodejs/packages/protractor/test/protractor-2/_devserver_launcher.amd_names_shim.js: could not locate fileFailed to read script build_bazel_rules_nodejs/packages/protractor/test/protractor-2/_devserver_launcher.amd_names_shim.js: open : no such file or directory

However if I throw this code in there

other, _ := bazel.Runfile("packages/protractor/test/protractor-2/_devserver_launcher.amd_names_shim.js")
	fmt.Printf("other runfile %v\n", other)

it prints

other runfile /usr/local/google/home/alexeagle/.cache/bazel/_bazel_alexeagle/c410d6070ef2d359d26ac4aeb886e1ea/sandbox/linux-sandbox/757/execroot/build_bazel_rules_nodejs/bazel-out/k8-fastbuild/bin/packages/protractor/test/protractor-2/devserver_test_chromium-local.runfiles/build_bazel_rules_nodejs/packages/protractor/test/protractor-2/_devserver_launcher.amd_names_shim.js

which makes me think that the runfile now has to be workspace-relative instead of workspace-absolute?

@alexeagle
Copy link
Collaborator Author

I commented on the PR that introduced the change: bazel-contrib/rules_go#2076

@alexeagle alexeagle changed the title Cannot update to rules_go 0.19.1 Cannot update to rules_go to 0.18.7 or later Aug 12, 2019
@alexeagle
Copy link
Collaborator Author

For now I worked around this issue by patching out the breaking commit:
bazelbuild/rules_typescript@73ba776

keeping this open since we will eventually get a merge conflict with that patch in a future rules_go release.

@alexeagle alexeagle added cleanup Tech debt, resolving it improves our own velocity package:typescript labels Aug 29, 2019
@alexeagle
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Development

No branches or pull requests

1 participant