Skip to content

Commit

Permalink
chore: support Bazelisk and stop using @bazel/bazel
Browse files Browse the repository at this point in the history
This switches the behavior of @bazel/create to stop making users download Bazel.
In a future cleanup I'll remove the mirror_bazel.sh and packages/bazel*..
(It's possible we still want those to publish Bazel 2.1 before we deprecate the package)
  • Loading branch information
alexeagle committed Feb 5, 2020
1 parent 87b2a64 commit f75d5f2
Show file tree
Hide file tree
Showing 30 changed files with 93 additions and 266 deletions.
1 change: 1 addition & 0 deletions .bazelversion
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.0.0
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ var_6: &init_bazel
run:
name: Initializing Bazel
command: |
# Symlink fetched bazel to /usr/local/bin/bazel
pathToBazel=$(ls $(realpath ./node_modules/@bazel/bazel-linux_x64)/bazel-*)
# Symlink fetched bazelisk to /usr/local/bin/bazel
pathToBazel=$(realpath ./node_modules/@bazel/bazelisk/bazelisk-linux_amd64)
sudo ln -fs $pathToBazel /usr/local/bin/bazel
echo "Bazel version:"
bazel version
Expand Down
1 change: 1 addition & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ codeowners(

# END-INTERNAL
exports_files([
".bazelversion",
"common.bazelrc",
"tsconfig.json",
"package.json",
Expand Down
20 changes: 1 addition & 19 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
load("//:index.bzl", "BAZEL_VERSION")

#
# Check that build is using a minimum compatible bazel version
#

load("//internal/common:check_bazel_version.bzl", "check_bazel_version")

# 0.18.0: support for .bazelignore
# 0.23.0: required fix for pkg_tar strip_prefix
# 0.26.0: managed_directories feature added
check_bazel_version(
message = """
You no longer need to install Bazel on your machine.
rules_nodejs has a dependency on the @bazel/bazel package which supplies it.
Try running `yarn bazel` instead.
""",
minimum_bazel_version = "0.26.0",
)

#
# Nested package worksapces required to build packages & reference rules
# Nested package workspaces required to build packages & reference rules
#

load("//packages:index.bzl", "NESTED_PACKAGES")
Expand Down
9 changes: 5 additions & 4 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,17 @@ stylesheet: docs
## Custom installation

First, you need Bazel.
We recommend fetching it from npm to keep your frontend workflow similar.
We recommend using Bazelisk, which is a version-selection wrapper, similar to
the `nvm` tool managing your version of Node. This is available on npm.

```sh
$ yarn add -D @bazel/bazel @bazel/ibazel
$ yarn add -D @bazel/bazelisk @bazel/ibazel
# or
$ npm install --save-dev @bazel/bazel @bazel/ibazel
$ npm install --save-dev @bazel/bazelisk @bazel/ibazel
```

> You could install a current bazel distribution, following the [bazel instructions].
> This has the advantage of setting up Bazel command-line completion.
> If you use Bazelisk, see [this workaround](https://github.com/bazelbuild/bazelisk/issues/29#issuecomment-478062147) to get working command-line completion.
Next, create a `WORKSPACE` file in your project root (or edit the existing one)
containing:
Expand Down
2 changes: 2 additions & 0 deletions examples/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ example_integration_test(
name = "examples_angular",
timeout = "long",
npm_packages = {
"//packages/hide-bazel-files:npm_package": "@bazel/hide-bazel-files",
"//packages/karma:npm_package": "@bazel/karma",
"//packages/protractor:npm_package": "@bazel/protractor",
"//packages/rollup:npm_package": "@bazel/rollup",
Expand All @@ -41,6 +42,7 @@ example_integration_test(
name = "examples_angular_view_engine",
timeout = "long",
npm_packages = {
"//packages/hide-bazel-files:npm_package": "@bazel/hide-bazel-files",
"//packages/karma:npm_package": "@bazel/karma",
"//packages/protractor:npm_package": "@bazel/protractor",
"//packages/rollup:npm_package": "@bazel/rollup",
Expand Down
2 changes: 1 addition & 1 deletion examples/angular/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ You simply run `yarn` commands shown below, and don't need to install Bazel or a
If you're a full-stack developer, you might be using Bazel for your backend already.
In this case, you should install Bazel following instructions at http://bazel.build.
Also install `ibazel`, which is a watch mode for Bazel not included in the standard distribution. See https://github.com/bazelbuild/bazel-watcher#installation.
The `WORKSPACE` file has a `check_bazel_version` call which will print an error if your Bazel version is not in the supported range.
You should have a `.bazelversion` file which will ensure Bazel prints an error if your Bazel version is not in the supported range.
You simply run `bazel` commands shown below, and don't need to install NodeJS, yarn, or any other dependencies.

## Development
Expand Down
15 changes: 1 addition & 14 deletions examples/angular/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,7 @@ http_archive(
)

# Check the bazel version and download npm dependencies
load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "yarn_install")

# Bazel version must be at least the following version because:
# - 0.27.0 Adds managed directories support
check_bazel_version(
message = """
You no longer need to install Bazel on your machine.
Angular has a dependency on the @bazel/bazel package which supplies it.
Try running `yarn bazel` instead.
(If you did run that, check that you've got a fresh `yarn install`)
""",
minimum_bazel_version = "0.27.0",
)
load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")

# Setup the Node.js toolchain & install our npm dependencies into @npm
yarn_install(
Expand Down
3 changes: 2 additions & 1 deletion examples/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@
"@babel/cli": "^7.6.0",
"@babel/core": "^7.6.0",
"@babel/preset-env": "^7.6.0",
"@bazel/bazel": "^2.0.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/benchmark-runner": "^0.1.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/hide-bazel-files": "^1.2.4",
"@bazel/ibazel": "^0.11.1",
"@bazel/karma": "^1.2.4",
"@bazel/protractor": "^1.2.4",
Expand Down
37 changes: 8 additions & 29 deletions examples/angular/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -785,31 +785,10 @@
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-2.0.0.tgz#bd678069216dd470c6816a22c405f21e7f048038"
integrity sha512-I/pP+B+2xfY0g+OEpEcVnk8rizuC761pAzBOQjP3b+gz3AzeRgm05CpcSY7tfPIppMSYoy3uTZJ1XlwgUg7IQQ==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-2.0.0.tgz#2c76e3301e9178a90ec3ad00649e89b953eda0b7"
integrity sha512-iOr45G+511IbP7e+ISriG97WpfCAVXekTrTgL5mGg3NDBFCVNs350VquHAvmlXAoP5+IEug2pCOlkdEl4bLl8g==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-2.0.0.tgz#f12ac0738d2eac0fd255f099776194807cedfe50"
integrity sha512-5qs2qoa/paG/YYEM0yvrwuJIShoPVK2FX+Oz9jEWAQJsmU4drHA9Aq+gbBOirEFLmvYhleZ9XORCwu/5uAo8vA==

"@bazel/bazel@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel/-/bazel-2.0.0.tgz#feb8cf5a40ea6437ef69cac2a92072118b11c230"
integrity sha512-KQbv5dHNSfutbhXCc3KVMuBXPpUh6Af/hT9IRIaMTuiB6Nq2gEW9Z3aNqncopdZqV848V/qYxnqPnQ+S37fMyQ==
dependencies:
"@bazel/hide-bazel-files" latest
optionalDependencies:
"@bazel/bazel-darwin_x64" "2.0.0"
"@bazel/bazel-linux_x64" "2.0.0"
"@bazel/bazel-win32_x64" "2.0.0"
"@bazel/bazelisk@^1.3.0":
version "1.3.0"
resolved "https://registry.yarnpkg.com/@bazel/bazelisk/-/bazelisk-1.3.0.tgz#dc312dd30ad01e9af86e53b40795ab6e545fa55b"
integrity sha512-73H1nq3572tTf+dhDT86aWQN+LCyfxrh05jabqPXp6cpR8soxte3gS5oUqkN36fUe+J2HzNiV4CXZTz4Xytd3Q==

"@bazel/benchmark-runner@^0.1.0":
version "0.1.0"
Expand Down Expand Up @@ -845,10 +824,10 @@
"@bazel/buildifier-linux_x64" "0.29.0"
"@bazel/buildifier-win32_x64" "0.29.0"

"@bazel/hide-bazel-files@latest":
version "0.32.2"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-0.32.2.tgz#a482855eafbccb56b1fce0d92ff922c2c6e0a90c"
integrity sha512-585XY53mhMZaCjEQJ+aDqkmydWZbuXsKrZsSpoW9YeAVEH0poQY3YhdyCPmMVBo7/l1mkrqpFuOK5BpECfwdtA==
"@bazel/hide-bazel-files@^1.2.4":
version "1.2.4"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-1.2.4.tgz#fe00f2bbceb8e1a17bedde7616bef4810849c7f5"
integrity sha512-KZX4MkJOMtZT1DwFmjCWJNCUKcwbYBrv3Q++peoWkzJPcHGbt5nLFjt8Gzagi2GY7GRqp8WAut0E+eOGdhvkEg==

"@bazel/[email protected]":
version "0.3.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/angular_bazel_architect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@angular/cli": "9.0.0-rc.10",
"@angular/compiler-cli": "9.0.0-rc.10",
"@angular/language-service": "9.0.0-rc.11",
"@bazel/bazel": "^2.0.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/ibazel": "^0.11.1",
"@types/jasmine": "~3.3.8",
Expand Down
34 changes: 4 additions & 30 deletions examples/angular_bazel_architect/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1020,31 +1020,10 @@
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-2.0.0.tgz#bd678069216dd470c6816a22c405f21e7f048038"
integrity sha512-I/pP+B+2xfY0g+OEpEcVnk8rizuC761pAzBOQjP3b+gz3AzeRgm05CpcSY7tfPIppMSYoy3uTZJ1XlwgUg7IQQ==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-2.0.0.tgz#2c76e3301e9178a90ec3ad00649e89b953eda0b7"
integrity sha512-iOr45G+511IbP7e+ISriG97WpfCAVXekTrTgL5mGg3NDBFCVNs350VquHAvmlXAoP5+IEug2pCOlkdEl4bLl8g==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-2.0.0.tgz#f12ac0738d2eac0fd255f099776194807cedfe50"
integrity sha512-5qs2qoa/paG/YYEM0yvrwuJIShoPVK2FX+Oz9jEWAQJsmU4drHA9Aq+gbBOirEFLmvYhleZ9XORCwu/5uAo8vA==

"@bazel/bazel@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel/-/bazel-2.0.0.tgz#feb8cf5a40ea6437ef69cac2a92072118b11c230"
integrity sha512-KQbv5dHNSfutbhXCc3KVMuBXPpUh6Af/hT9IRIaMTuiB6Nq2gEW9Z3aNqncopdZqV848V/qYxnqPnQ+S37fMyQ==
dependencies:
"@bazel/hide-bazel-files" latest
optionalDependencies:
"@bazel/bazel-darwin_x64" "2.0.0"
"@bazel/bazel-linux_x64" "2.0.0"
"@bazel/bazel-win32_x64" "2.0.0"
"@bazel/bazelisk@^1.3.0":
version "1.3.0"
resolved "https://registry.yarnpkg.com/@bazel/bazelisk/-/bazelisk-1.3.0.tgz#dc312dd30ad01e9af86e53b40795ab6e545fa55b"
integrity sha512-73H1nq3572tTf+dhDT86aWQN+LCyfxrh05jabqPXp6cpR8soxte3gS5oUqkN36fUe+J2HzNiV4CXZTz4Xytd3Q==

"@bazel/[email protected]":
version "0.29.0"
Expand All @@ -1070,11 +1049,6 @@
"@bazel/buildifier-linux_x64" "0.29.0"
"@bazel/buildifier-win32_x64" "0.29.0"

"@bazel/hide-bazel-files@latest":
version "1.0.0"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-1.0.0.tgz#779070dcb5ae121ff6c72d73bf3fb7bf68285d75"
integrity sha512-dfw2W7xDUPlRMcDMVO8gDkX9Xb7Thy3sP4PDODv+eiHOvwIi116X/wwy7mQUZISkJdEJ1zWy9ydpzvfetpYh4w==

"@bazel/ibazel@^0.11.1":
version "0.11.1"
resolved "https://registry.yarnpkg.com/@bazel/ibazel/-/ibazel-0.11.1.tgz#c07ceaded388f1e39d6aa732953e0dd04f3dbdf0"
Expand Down
15 changes: 1 addition & 14 deletions examples/angular_view_engine/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,7 @@ http_archive(
)

# Check the bazel version and download npm dependencies
load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "yarn_install")

# Bazel version must be at least the following version because:
# - 0.27.0 Adds managed directories support
check_bazel_version(
message = """
You no longer need to install Bazel on your machine.
Angular has a dependency on the @bazel/bazel package which supplies it.
Try running `yarn bazel` instead.
(If you did run that, check that you've got a fresh `yarn install`)
""",
minimum_bazel_version = "0.27.0",
)
load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")

# Setup the Node.js toolchain & install our npm dependencies into @npm
yarn_install(
Expand Down
3 changes: 2 additions & 1 deletion examples/angular_view_engine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@
"@babel/cli": "^7.6.0",
"@babel/core": "^7.6.0",
"@babel/preset-env": "^7.6.0",
"@bazel/bazel": "^2.0.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/benchmark-runner": "^0.1.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/hide-bazel-files": "^1.2.4",
"@bazel/ibazel": "^0.11.1",
"@bazel/karma": "^1.2.4",
"@bazel/protractor": "^1.2.4",
Expand Down
37 changes: 8 additions & 29 deletions examples/angular_view_engine/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -803,31 +803,10 @@
lodash "^4.17.13"
to-fast-properties "^2.0.0"

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-2.0.0.tgz#bd678069216dd470c6816a22c405f21e7f048038"
integrity sha512-I/pP+B+2xfY0g+OEpEcVnk8rizuC761pAzBOQjP3b+gz3AzeRgm05CpcSY7tfPIppMSYoy3uTZJ1XlwgUg7IQQ==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-2.0.0.tgz#2c76e3301e9178a90ec3ad00649e89b953eda0b7"
integrity sha512-iOr45G+511IbP7e+ISriG97WpfCAVXekTrTgL5mGg3NDBFCVNs350VquHAvmlXAoP5+IEug2pCOlkdEl4bLl8g==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-2.0.0.tgz#f12ac0738d2eac0fd255f099776194807cedfe50"
integrity sha512-5qs2qoa/paG/YYEM0yvrwuJIShoPVK2FX+Oz9jEWAQJsmU4drHA9Aq+gbBOirEFLmvYhleZ9XORCwu/5uAo8vA==

"@bazel/bazel@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel/-/bazel-2.0.0.tgz#feb8cf5a40ea6437ef69cac2a92072118b11c230"
integrity sha512-KQbv5dHNSfutbhXCc3KVMuBXPpUh6Af/hT9IRIaMTuiB6Nq2gEW9Z3aNqncopdZqV848V/qYxnqPnQ+S37fMyQ==
dependencies:
"@bazel/hide-bazel-files" latest
optionalDependencies:
"@bazel/bazel-darwin_x64" "2.0.0"
"@bazel/bazel-linux_x64" "2.0.0"
"@bazel/bazel-win32_x64" "2.0.0"
"@bazel/bazelisk@^1.3.0":
version "1.3.0"
resolved "https://registry.yarnpkg.com/@bazel/bazelisk/-/bazelisk-1.3.0.tgz#dc312dd30ad01e9af86e53b40795ab6e545fa55b"
integrity sha512-73H1nq3572tTf+dhDT86aWQN+LCyfxrh05jabqPXp6cpR8soxte3gS5oUqkN36fUe+J2HzNiV4CXZTz4Xytd3Q==

"@bazel/benchmark-runner@^0.1.0":
version "0.1.0"
Expand Down Expand Up @@ -863,10 +842,10 @@
"@bazel/buildifier-linux_x64" "0.29.0"
"@bazel/buildifier-win32_x64" "0.29.0"

"@bazel/hide-bazel-files@latest":
version "0.32.2"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-0.32.2.tgz#a482855eafbccb56b1fce0d92ff922c2c6e0a90c"
integrity sha512-585XY53mhMZaCjEQJ+aDqkmydWZbuXsKrZsSpoW9YeAVEH0poQY3YhdyCPmMVBo7/l1mkrqpFuOK5BpECfwdtA==
"@bazel/hide-bazel-files@^1.2.4":
version "1.2.4"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-1.2.4.tgz#fe00f2bbceb8e1a17bedde7616bef4810849c7f5"
integrity sha512-KZX4MkJOMtZT1DwFmjCWJNCUKcwbYBrv3Q++peoWkzJPcHGbt5nLFjt8Gzagi2GY7GRqp8WAut0E+eOGdhvkEg==

"@bazel/[email protected]":
version "0.3.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/nestjs/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"dependencies": {
"@bazel/bazel": "^2.0.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/ibazel": "^0.11.1",
"@bazel/jasmine": "^1.2.4",
"@nestjs/common": "6.5.2",
Expand Down
34 changes: 4 additions & 30 deletions examples/nestjs/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,10 @@
# yarn lockfile v1


"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-darwin_x64/-/bazel-darwin_x64-2.0.0.tgz#bd678069216dd470c6816a22c405f21e7f048038"
integrity sha512-I/pP+B+2xfY0g+OEpEcVnk8rizuC761pAzBOQjP3b+gz3AzeRgm05CpcSY7tfPIppMSYoy3uTZJ1XlwgUg7IQQ==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-linux_x64/-/bazel-linux_x64-2.0.0.tgz#2c76e3301e9178a90ec3ad00649e89b953eda0b7"
integrity sha512-iOr45G+511IbP7e+ISriG97WpfCAVXekTrTgL5mGg3NDBFCVNs350VquHAvmlXAoP5+IEug2pCOlkdEl4bLl8g==

"@bazel/[email protected]":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel-win32_x64/-/bazel-win32_x64-2.0.0.tgz#f12ac0738d2eac0fd255f099776194807cedfe50"
integrity sha512-5qs2qoa/paG/YYEM0yvrwuJIShoPVK2FX+Oz9jEWAQJsmU4drHA9Aq+gbBOirEFLmvYhleZ9XORCwu/5uAo8vA==

"@bazel/bazel@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@bazel/bazel/-/bazel-2.0.0.tgz#feb8cf5a40ea6437ef69cac2a92072118b11c230"
integrity sha512-KQbv5dHNSfutbhXCc3KVMuBXPpUh6Af/hT9IRIaMTuiB6Nq2gEW9Z3aNqncopdZqV848V/qYxnqPnQ+S37fMyQ==
dependencies:
"@bazel/hide-bazel-files" latest
optionalDependencies:
"@bazel/bazel-darwin_x64" "2.0.0"
"@bazel/bazel-linux_x64" "2.0.0"
"@bazel/bazel-win32_x64" "2.0.0"

"@bazel/hide-bazel-files@latest":
version "1.0.1"
resolved "https://registry.yarnpkg.com/@bazel/hide-bazel-files/-/hide-bazel-files-1.0.1.tgz#bfba5c73f307cd69c25411084023f60cdd89ef01"
integrity sha512-3unoDYZIGxtePTa/bhsWZ0pxtI/G9LYr41Kkb1ZpSaSz27ZDvj6Aysbc0u9TNGTZhqkcr/w66OC9pvmeys4YnQ==
"@bazel/bazelisk@^1.3.0":
version "1.3.0"
resolved "https://registry.yarnpkg.com/@bazel/bazelisk/-/bazelisk-1.3.0.tgz#dc312dd30ad01e9af86e53b40795ab6e545fa55b"
integrity sha512-73H1nq3572tTf+dhDT86aWQN+LCyfxrh05jabqPXp6cpR8soxte3gS5oUqkN36fUe+J2HzNiV4CXZTz4Xytd3Q==

"@bazel/ibazel@^0.11.1":
version "0.11.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/react_webpack/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"devDependencies": {
"@bazel/bazel": "^2.0.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/ibazel": "^0.11.1",
"@types/react": "^16.9.5",
Expand Down
Loading

2 comments on commit f75d5f2

@philwo
Copy link
Contributor

@philwo philwo commented on f75d5f2 Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeagle FYI looks like this broke the //examples:examples_angular_bazel_architect test on CI: https://buildkite.com/bazel/rules-nodejs-nodejs/builds/5751

@gregmagolan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh. Yes. In-flight conflict with two PRs. Fix PR #1607. Thanks @philwo

Please sign in to comment.