From f50dea315cfff72b6ff09c86f2f444f5dd128a8f Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Tue, 17 Dec 2019 01:31:33 -0800 Subject: [PATCH] refactor: remove unused exclude_packages from npm_install & yarn_install BREAKING CHANGE: Removed unused exclude_packages from npm_install & yarn_install --- e2e/ts_devserver/WORKSPACE | 5 ++++- examples/app/WORKSPACE | 5 ++++- examples/web_testing/WORKSPACE | 5 ++++- examples/webapp/WORKSPACE | 5 ++++- internal/npm_install/npm_install.bzl | 3 --- packages/karma/docs/install.md | 5 ++++- 6 files changed, 20 insertions(+), 8 deletions(-) diff --git a/e2e/ts_devserver/WORKSPACE b/e2e/ts_devserver/WORKSPACE index a51b23b832..71269e8e1b 100644 --- a/e2e/ts_devserver/WORKSPACE +++ b/e2e/ts_devserver/WORKSPACE @@ -52,4 +52,7 @@ web_test_repositories() load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") -browser_repositories(chromium = True) +browser_repositories( + chromium = True, + firefox = True, +) diff --git a/examples/app/WORKSPACE b/examples/app/WORKSPACE index a8b2b74bf5..3949aa7fc8 100644 --- a/examples/app/WORKSPACE +++ b/examples/app/WORKSPACE @@ -52,4 +52,7 @@ web_test_repositories() load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") -browser_repositories(chromium = True) +browser_repositories( + chromium = True, + firefox = True, +) diff --git a/examples/web_testing/WORKSPACE b/examples/web_testing/WORKSPACE index 61a349e819..fb3a207877 100644 --- a/examples/web_testing/WORKSPACE +++ b/examples/web_testing/WORKSPACE @@ -47,7 +47,10 @@ web_test_repositories() load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") -browser_repositories(chromium = True) +browser_repositories( + chromium = True, + firefox = True, +) load("@npm_bazel_typescript//:index.bzl", "ts_setup_workspace") diff --git a/examples/webapp/WORKSPACE b/examples/webapp/WORKSPACE index ab7f667231..2f51e0f6a2 100644 --- a/examples/webapp/WORKSPACE +++ b/examples/webapp/WORKSPACE @@ -48,4 +48,7 @@ web_test_repositories() load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") -browser_repositories(chromium = True) +browser_repositories( + chromium = True, + firefox = True, +) diff --git a/internal/npm_install/npm_install.bzl b/internal/npm_install/npm_install.bzl index 9fe884dfe6..6ea88ac9af 100644 --- a/internal/npm_install/npm_install.bzl +++ b/internal/npm_install/npm_install.bzl @@ -66,9 +66,6 @@ If symlink_node_modules is True, this attribute is ignored since the dependency manager will run in the package.json location. """, ), - "exclude_packages": attr.string_list( - doc = """DEPRECATED. This attribute is no longer used.""", - ), "included_files": attr.string_list( doc = """List of file extensions to be included in the npm package targets. diff --git a/packages/karma/docs/install.md b/packages/karma/docs/install.md index e6189ba1f7..b0a9f9439b 100644 --- a/packages/karma/docs/install.md +++ b/packages/karma/docs/install.md @@ -34,7 +34,10 @@ web_test_repositories() load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories") -browser_repositories(chromium = True) +browser_repositories( + chromium = True, + firefox = True, +) ``` ## Installing with self-managed dependencies