From 829f068143d4c7e1958992165d822805667e7151 Mon Sep 17 00:00:00 2001 From: Matt Mackay Date: Sun, 18 Oct 2020 08:34:34 -0400 Subject: [PATCH] feat(builtin): flip the default of the strict_visibility flag on the npm and yarn install rules to True --- internal/npm_install/npm_install.bzl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/npm_install/npm_install.bzl b/internal/npm_install/npm_install.bzl index b2ae33529e..9f6c12483d 100644 --- a/internal/npm_install/npm_install.bzl +++ b/internal/npm_install/npm_install.bzl @@ -84,14 +84,12 @@ fine grained npm dependencies. doc = "If stdout and stderr should be printed to the terminal.", ), "strict_visibility": attr.bool( - default = False, + default = True, doc = """Turn on stricter visibility for generated BUILD.bazel files When enabled, only dependencies within the given `package.json` file are given public visibility. All transitive dependencies are given limited visibility, enforcing that all direct dependencies are listed in the `package.json` file. - -Currently the default is set `False`, but will likely be flipped `True` in rules_nodejs 3.0.0 """, ), "symlink_node_modules": attr.bool(