From 012a21e6a8c1a1152218fa6fd19feb77df492bba Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Mon, 20 May 2019 11:18:04 -0700 Subject: [PATCH] Minimum Bazel version is now 0.26.0 as yarn_install & npm_install depend on managed_directories by default (#704) --- WORKSPACE | 3 ++- internal/common/check_bazel_version.bzl | 2 +- internal/node/node_repositories.bzl | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 360f8db6ea..8e5a5115a4 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -30,7 +30,8 @@ load("//internal/common:check_bazel_version.bzl", "check_bazel_version") # 0.18.0: support for .bazelignore # 0.23.0: required fix for pkg_tar strip_prefix -check_bazel_version(minimum_bazel_version = "0.23.0") +# 0.26.0: managed_directories feature added +check_bazel_version(minimum_bazel_version = "0.26.0") # # Load and install our dependencies downloaded above. diff --git a/internal/common/check_bazel_version.bzl b/internal/common/check_bazel_version.bzl index 595bf352b1..4029f6a7e5 100644 --- a/internal/common/check_bazel_version.bzl +++ b/internal/common/check_bazel_version.bzl @@ -35,7 +35,7 @@ def check_bazel_version(minimum_bazel_version, message = ""): ``` # in WORKSPACE: load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version") - check_bazel_version("0.11.0") + check_bazel_version("0.26.0") ``` Args: diff --git a/internal/node/node_repositories.bzl b/internal/node/node_repositories.bzl index db0706bf73..3a9dbef2fb 100644 --- a/internal/node/node_repositories.bzl +++ b/internal/node/node_repositories.bzl @@ -535,7 +535,8 @@ def node_repositories( # 0.14.0: @bazel_tools//tools/bash/runfiles is required for nodejs # 0.17.1: allow @ in package names is required for fine grained deps # 0.21.0: repository_ctx.report_progress API - check_bazel_version("0.21.0") + # 0.26.0: managed_directories feature added + check_bazel_version("0.26.0") _maybe( _nodejs_repo,