Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_config_setting_private_default_visibility will break rules_jsonnet in Bazel 7.0 #163

Closed
keertk opened this issue Nov 23, 2022 · 3 comments

Comments

@keertk
Copy link

keertk commented Nov 23, 2022

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_jsonnet. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break rules_jsonnet in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break rules_jsonnet in Bazel 7.0 Nov 29, 2022
@sgowroji
Copy link

sgowroji commented Jun 19, 2023

Hi @sparkprime Team, Could you please look in to this issue.Thanks!

@EdSchouten
Copy link
Collaborator

@keertk @sgowroji Is this still an issue? I cannot reproduce this with Bazel 7.1.1:

$ cd rules_jsonnet/examples
$ bazel test --incompatible_config_setting_private_default_visibility //...
...
Executed 21 out of 21 tests: 21 tests pass.

@sgowroji
Copy link

sgowroji commented Apr 4, 2024

Yes we can close this issue now. Thanks for updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants