Remove GoSource/GoLibrary from test/binary rules #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am concerned that this will make it more difficult for other rules to interop with Go rules. Could we instead make it so that |
Yeah that's a fair concern. I think they are only emitted for gopackagesdriver, but perhaps we can make that work differently, I'll take a look |
dzbarsky
force-pushed
the
go_source_info
branch
from
6c1010d to
5c860cd
Compare
dzbarsky
changed the title
dzbarsky
force-pushed
the
go_source_info
branch
from
5c860cd to
e35cb52
Compare
dzbarsky
commented
Aug 15, 2024
|
@fmeum ok I like your suggestion better, thanks. PTAL |
dzbarsky
force-pushed
the
go_source_info
branch
from
2f16da2 to
51d8b1f
Compare
fmeum
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Starlark cleanup
What does this PR do? Why is it needed?
We don't want go_binary or go_test targets to be included in
depsorembed. We have a check for it today, but we can push this into the starlark type system by ensuring they don't have these providers.Which issues(s) does this PR fix?
Fixes #
Other notes for review