-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't set AssemblyVersion etc attributes #423
Comments
I think that makes sense that you could provide these attributes to the targets. Does it not work to just supply the |
Did you use some workaround for this? Is it not enough to supply the AssemblyInfo.cs into the |
I wrote an 'assembly_info' rule that generates an assemblyinfo.cs file from a template for the current version of the product, and then wrote wrappers for each csharp_ rule. The wrapper calls the rule and adds the generated file into the build of every csharp library in our product. |
In case you would like to upstream anything, or if it is helpful to others, this is what I set up: This is based on code I found here: https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/private/generated_assembly_info.bzl AssemblyInfo.cs.template:
generated_assembly_info.bzl
my_csharp_library.bzl
|
I need to set AssemblyVersion on the libraries we are building. Actually, three attributes:
In our existing msbuild, these are set in a .cs file and that's pulled into the assembly with /property:BuildVersionFile=above.cs
I understand the attributes can also be supplied directly to msbuild as attributes.
This is a new blocker for us... Can this be supported?
The text was updated successfully, but these errors were encountered: