Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store download URL for packages used by nuget_repo / nuget_archive #401

Open
WhoCalledInTheFleet opened this issue Dec 1, 2023 · 1 comment

Comments

@WhoCalledInTheFleet
Copy link

There are NuGet repository implementations (for example that of JFrog Artifactory) that use different URL patterns for hosting NuGet packages:

https://ART_REPO/artifactory/api/nuget/nuget-all/Download/Some.Package.Name/1.0.0

Either at download time the rule should call FindPackagesById() and read the src attribute of the <content> element; Or we should have the package def (and also paket2bazel) store the full download URL instead of just version and sources.

@purkhusid
Copy link
Collaborator

I'm pretty sure that this is a bug in Artifactory since it does not seem to follow the convention that is outlined here https://learn.microsoft.com/en-us/nuget/api/overview

There is a workaround mentioned here: #379

I've been thinking that it might make sense to get rid of all the nuget URL handling and have just the full download URL instead. I don't have time to look into that currently so I don't expect that to be fixed very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants