Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible handling of NuGet package "build" folder #388

Open
Inirit opened this issue Sep 28, 2023 · 1 comment
Open

Incompatible handling of NuGet package "build" folder #388

Inirit opened this issue Sep 28, 2023 · 1 comment

Comments

@Inirit
Copy link

Inirit commented Sep 28, 2023

Newer versions of rules_dotnet brought support for the "build" folder that some NuGet packages have. According to #369, this implementation was based on NETStandard.Library as an example of the expected directory structure (where dlls are under framework and lib/ref directories).

However, not all NuGet packages structure their "build" folder in the same way as NETStandard.Library, e.g. coverlet.collector and NUnit3TestAdapter have dlls directly under a framework directory and Microsoft.TestPlatform.TestHost has dlls under framework and architecture directories. rules_dotnet won't collect these dlls and therefore they won't be available to the build.

@Inirit
Copy link
Author

Inirit commented Sep 29, 2023

I have a very naive suggestion for a workaround (at least for my purposes): Expose all the files of a NuGet package as a filegroup. This filegroup would exist alongside the other filegroups and would help enable the consumer to do whatever wonky custom thing they need to do when a more "official" solution is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant