Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): Enable pre-commit CI and renovate #130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hofbi
Copy link

@hofbi hofbi commented Dec 8, 2024

Since the rules already prvide a pre-commit config, we should also make sure the checks pass CI and hooks stay up to date.

@fmeum
Copy link
Member

fmeum commented Dec 9, 2024

@alexeagle

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, but let's land your bazel-lib usage of it and get a few days usage to verify it behaves how rules authors will want, before we update the template.

@hofbi
Copy link
Author

hofbi commented Dec 9, 2024

I think it looks good, but let's land your bazel-lib usage of it and get a few days usage to verify it behaves how rules authors will want, before we update the template.

Sounds good. I pushed another commit fixing all pre-commit issues so that we can merge in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants