bazel-contrib · alexeagle · Dec 11, 2024 · Dec 8, 2024 · Dec 8, 2024 · Dec 11, 2024
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -148,10 +148,15 @@ jobs:
       - name: Verify bcr patches
         if: matrix.folder == '.' && matrix.bzlmod == '1' && matrix.os == 'ubuntu' && matrix.bazel-version.major != '6'
         run: patch --dry-run -p1 < .bcr/patches/*.patch
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pre-commit/[email protected]
   # For branch protection settings, this job provides a "stable" name that can be used to gate PR merges
   # on "all matrix jobs were successful".
   conclusion:
-    needs: test
+    needs: [test, pre-commit]
     runs-on: ubuntu-latest
     if: always()
     steps:

diff --git a/.shellcheckrc b/.shellcheckrc
@@ -3,4 +3,4 @@ enable=quote-safe-variables
 # Turn on warnings for unassigned uppercase variables
 enable=check-unassigned-uppercase
 
-#enable=require-variable-braces
+#enable=require-variable-braces
diff --git a/.typos.toml b/.typos.toml
@@ -1,2 +1,3 @@
 [default.extend-identifiers]
 MODULEs = "MODULEs"  # Else it becomes MODULEEs
+HashiCorp = "HashiCorp"
diff --git a/e2e/smoke/BUILD.bazel b/e2e/smoke/BUILD.bazel
@@ -121,9 +121,6 @@ go_test(
     name = "test_preserve_mtime",
     size = "small",
     srcs = ["test_preserve_mtime.go"],
-    deps = [
-        "@io_bazel_rules_go//go/tools/bazel:go_default_library",
-    ],
     data = [
         "d",
         ":copy_directory_mtime_case",
@@ -135,5 +132,12 @@ go_test(
     #   bazel test :test_preserve_mtime # This test should pass
     #   touch d/1 # Update the mtime, in the CI environment this is done with the SCM integration.
     #   bazel test :test_preserve_mtime # This test now fails
-    tags = ["no-remote", "external", "manual"],
+    tags = [
+        "external",
+        "manual",
+        "no-remote",
+    ],
+    deps = [
+        "@io_bazel_rules_go//go/tools/bazel:go_default_library",
+    ],
 )
diff --git a/e2e/smoke/MODULE.bazel b/e2e/smoke/MODULE.bazel
@@ -5,4 +5,4 @@ local_path_override(
 )
 
 bazel_dep(name = "bazel_skylib", version = "1.7.1", dev_dependency = True)
-bazel_dep(name = "rules_go",  version = "0.50.1", repo_name = "io_bazel_rules_go", dev_dependency = True)
+bazel_dep(name = "rules_go", version = "0.50.1", dev_dependency = True, repo_name = "io_bazel_rules_go")
diff --git a/e2e/smoke/test_preserve_mtime.go b/e2e/smoke/test_preserve_mtime.go
@@ -26,36 +26,36 @@ func mtime(path string) (time.Time, error) {
 
 func (r runfilePath) osPath() (string, error) {
 	dirPath, err := bazel.Runfile(r.runfileDir)
-	if err != nil{
+	if err != nil {
 		return "", err
 	}
 	parts := append([]string{dirPath}, r.subPaths...)
 	return filepath.Join(parts...), nil
 }
 
 func TestPreserveMTime(t *testing.T) {
-	cases := map[string]struct{
+	cases := map[string]struct {
 		original runfilePath
-		copied runfilePath
+		copied   runfilePath
 	}{
 		"copy_directory": {
 			original: runfilePath{
 				runfileDir: "d",
-				subPaths: []string{"1"},
+				subPaths:   []string{"1"},
 			},
 			copied: runfilePath{
 				runfileDir: "copy_directory_mtime_out",
-				subPaths: []string{"1"},
+				subPaths:   []string{"1"},
 			},
 		},
 		"copy_to_directory": {
 			original: runfilePath{
 				runfileDir: "d",
-				subPaths: []string{"1"},
+				subPaths:   []string{"1"},
 			},
 			copied: runfilePath{
 				runfileDir: "copy_to_directory_mtime_out",
-				subPaths: []string{"d", "1"},
+				subPaths:   []string{"d", "1"},
 			},
 		},
 	}

diff --git a/lib/private/tar.bzl b/lib/private/tar.bzl
@@ -175,7 +175,7 @@ def _is_unused_inputs_enabled(attr):
         return False
     if attr.compute_unused_inputs == -1:
         return attr._compute_unused_inputs_flag[BuildSettingInfo].value
-    
+
     fail("Unexpected `compute_unused_inputs` value: {}".format(attr.compute_unused_inputs))
 
 def _is_unprunable(file):

diff --git a/lib/tests/expand_template/index.html b/lib/tests/expand_template/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <head>
     <script src="index.ts"></script>

diff --git a/lib/tests/transitions/BUILD.bazel b/lib/tests/transitions/BUILD.bazel
@@ -137,15 +137,21 @@ platform_transition_test(
     name = "transitioned_go_test_x86_64",
     binary = ":test_transition_test",
     # only run this test on an x86_64 host
-    target_compatible_with = [] if sorted(HOST_CONSTRAINTS) == ["@platforms//cpu:x86_64", "@platforms//os:linux"] else ["@platforms//:incompatible"],
+    target_compatible_with = [] if sorted(HOST_CONSTRAINTS) == [
+        "@platforms//cpu:x86_64",
+        "@platforms//os:linux",
+    ] else ["@platforms//:incompatible"],
     target_platform = "x86_64_linux",
 )
 
 platform_transition_test(
     name = "transitioned_go_test_arm64",
     binary = ":test_transition_test",
     # only run this test on an x86_64 host
-    target_compatible_with = [] if sorted(HOST_CONSTRAINTS) == ["@platforms//cpu:aarch64", "@platforms//os:linux"] else ["@platforms//:incompatible"],
+    target_compatible_with = [] if sorted(HOST_CONSTRAINTS) == [
+        "@platforms//cpu:aarch64",
+        "@platforms//os:linux",
+    ] else ["@platforms//:incompatible"],
     target_platform = "arm64_linux",
 )
 

diff --git a/tools/lint/vale/config/vocabularies/engineering/accept.txt b/tools/lint/vale/config/vocabularies/engineering/accept.txt
@@ -62,7 +62,7 @@ rebase
 mutex
 hotfix
 oncall
-poisioning
+poisoning
 statefulness
 teardown
 toolchain

diff --git a/tools/lint/vale/config/vocabularies/engineering/reject.txt b/tools/lint/vale/config/vocabularies/engineering/reject.txt
@@ -1 +1 @@
-bar
+bar