Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0: Refactor toolchain registration #593

Closed
alexeagle opened this issue Oct 6, 2023 · 0 comments · Fixed by #597
Closed

2.0: Refactor toolchain registration #593

alexeagle opened this issue Oct 6, 2023 · 0 comments · Fixed by #597
Assignees
@kormide
Labels
untriaged Requires traige
Milestone
2.0

Comments

@alexeagle
Copy link
Collaborator

Registering toolchains should be a separate call made by users, not tucked into aspect_bazel_lib_dependencies.
Under bzlmod, this should also allow registering your own toolchain rather than ours always taking priority, maybe with a second module extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kormide kormide

Labels
untriaged Requires traige
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

refactor: rework toolchain registration for WORKSPACE and bzlmod users kormide/bazel-lib
2 participants
@alexeagle @kormide