-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bzlmod: Reuse user-defined Go SDK for Gazelle bootstrap #1469
Comments
As an additional data point, it looks like this is even more of a problem for platforms not supported by On NixOS in particular, downloaded binaries do not work because there is no dynamic loader in the standard location. But it is still possible to register host toolchains, or toolchains from |
Assuming that Gazelle compiles with any reasonably recent Go SDK, we could have the I will gladly help anyone who wants to get started implementing this. |
I work in an environment that |
If it can help, I did some experiments here: ylecornec/rules_go@958b568 and managed to setup gazelle on a project compatible with both NixOS and Ubuntu. In this POC:
|
@ylecornec That looks pretty good. Could you split it into two parts, moving the addition of the new tag to the second one? The first one could be an easy merge, but I would like to think more about the API for the second part. |
Thanks, I split it into two parts and opened these PRs: |
The
gazelle
module currently always uses thego_default_sdk
defined byrules_go
, even if another module registers an SDK that takes precedence over the default one. This results in two SDKs being fetched when only a single one should be needed.Ideally we would be able to ascertain that a given SDK is sufficient to compile Gazelle with and just use that one instead of
go_default_sdk
.The text was updated successfully, but these errors were encountered: